Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions #13

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Additions #13

wants to merge 35 commits into from

Conversation

luison
Copy link

@luison luison commented Nov 3, 2014

This is the crude code a colleague has produced to suit our needs for a image repository and proxy as an alternate to one we already had based on picasa web albums, whichs api fails more and more everyday.

Changes are mainly in:

  • able to create any size based on params w,h not just fixed sizes
  • changes to pagination so we can see a complete XML files of the available images
  • added a "count" option to controller so we can determine total amount of images on search
  • added a feature to return the position "x" of a search instead of only by id
  • watermark for images on creation
  • changes to importer to add/update images
  • additional cache for queries
  • hash for user to use on non-logged URL queries

…de una imagen. Ademas permito buscar por posicion en etiquetas.
… el usuario actual en PreviewManagerComponent para poder añadir una marca de agua dependiendo del usuario que se conecte, además de añadir esto a la ruta de archivo generada.
@xemle
Copy link
Owner

xemle commented Nov 6, 2014

Thank you for your PR and the work on phtagr. I appreciate your time and your will a lot.

Unfortunately, it contains too many changes at once. Some changes break the database migration path (api column), some code parts are not clean and some comments are not in English.

If you like to apply your work and improvements I advice you to create smaller PRs for better review. Further, on basic changes (like database, query caches, arbitrary preview sizes) I would like to discuss these feature requests (and motivation) on the mailing list.

Do not hesitate to ask any question e.g. how to create a database migration. I will do my best for an kind of support.

SRJ9 added 20 commits December 1, 2014 18:49
…y que este coja de la base de datos los usuarios.
…bian creado media (subidas por el quickupload) no las creaba. Lo he modificado para que las cree.
* Arreglo de marca de agua en imagenes base
* Añado delete de imagenes
* Añado view de count de imagenes.
* Limpieza de cache por busqueda o especifica
…neamente los cambios que haya hecho en la foto. Aparte añado el enlace a la preview de la foto.
- Creo cache de queries.

En Controller/Component/FilterManagerComponent.php
- Comento un ELSE, lo que permite que se creen los medias que no existen en las importaciones.

En Controller/Component/ImageResizerComponent.php
- Permito algunos parametros por GET con w, h y zc

En Controller/Component/PreviewManagerComponent.php
- Creo marca de agua
- Distinto archivo de cache si tiene resize

SIN COMENTAR AUN:
-- Controller/Component/SearchComponent.php
-- Controller/ExplorerController.php
-- Controller/MediaController.php
-- Controller/OptionsController.php
-- Model/Media.php
-- View/Explorer/media.ctp
-- View/Options/profile.ctp
-- View/Explorer/count.ctp
-- View/Media/clean.ctp

Conflicts:

	Config/core.php
	Controller/Component/FilterManagerComponent.php
	Controller/Component/ImageResizerComponent.php
	Controller/Component/PreviewManagerComponent.php
	Controller/OptionsController.php
	Model/Media.php
	View/Options/profile.ctp
Conflicts:

	Controller/OptionsController.php
Conflicts:

	View/Options/profile.ctp
…en el import y en el upload.

Conflicts:

	Controller/Component/ImageResizerComponent.php
	Controller/Component/PreviewManagerComponent.php
	Controller/MediaController.php
@SRJ9 SRJ9 deleted the master branch December 2, 2014 11:01
@SRJ9 SRJ9 restored the master branch December 2, 2014 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants